]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
ALSA: hda - Use ALC_INIT_DEFAULT for really default initialization
authorTakashi Iwai <tiwai@suse.de>
Fri, 26 Nov 2010 16:11:18 +0000 (17:11 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 26 Nov 2010 16:11:18 +0000 (17:11 +0100)
When SKU assid gives no valid bits for 0x38, the driver didn't take
any action, so far.  This resulted in the missing initialization for
external amps, etc, thus the silent output in the end.

Especially users hit this problem on ALC888 newly since 2.6.35,
where the driver doesn't force to use ALC_INIT_DEFAULT any more.

This patch sets the default initialization scheme to use
ALC_INIT_DEFAULT when no valid bits are set for SKU assid.

Reference:
https://bugzilla.redhat.com/show_bug.cgi?id=657388

Reported-and-tested-by: Kyle McMartin <kyle@redhat.com>
Cc: <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_realtek.c

index 81a2a49b862cc8eb1e64b0371143a3c55f131dca..886d7c72936e9e2959042306c79d24383a8176a3 100644 (file)
@@ -1614,6 +1614,7 @@ do_sku:
                spec->init_amp = ALC_INIT_GPIO3;
                break;
        case 5:
+       default:
                spec->init_amp = ALC_INIT_DEFAULT;
                break;
        }