]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
Staging: cptm1217: move free under dereference
authorDan Carpenter <error27@gmail.com>
Sat, 13 Nov 2010 08:34:16 +0000 (11:34 +0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 16 Nov 2010 20:31:49 +0000 (12:31 -0800)
We dereference "ts" in the printk so move the kfree() down a line.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/cptm1217/clearpad_tm1217.c

index 269503f9516fc7f480a9284299ea36b659359f67..76e4b782d2fb93fbf993652189fa8d255264ebb7 100644 (file)
@@ -460,9 +460,9 @@ static int cp_tm1217_probe(struct i2c_client *client,
        for (i = 0; i < TOUCH_SUPPORTED; i++) {
                input_dev = input_allocate_device();
                if (input_dev == NULL) {
-                       kfree(ts);
                        dev_err(ts->dev,
                                "cp_tm1217:Input Device Struct alloc failed\n");
+                       kfree(ts);
                        return -ENOMEM;
                }
                input_info = &ts->cp_input_info[i];