]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
Staging: bcm: dereferencing before checking
authorDan Carpenter <error27@gmail.com>
Fri, 8 Oct 2010 12:56:35 +0000 (14:56 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 8 Oct 2010 14:29:55 +0000 (07:29 -0700)
I moved the check to see if "Adapter" was null in front of the
dereference.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/bcm/CmHost.c

index 0329f7dc7140018233e9d83f0aba78ffd369aa0b..b4113923e3ed4785badc476e6179701c03a1f14d 100644 (file)
@@ -1943,15 +1943,14 @@ ULONG SetUpTargetDsxBuffers(PMINI_ADAPTER Adapter)
        ULONG ulIndex=0;
        int Status;
 
+       if (!Adapter) {
+               BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL, "Adapter was NULL!!!");
+               return 0;
+       }
+
        if(Adapter->astTargetDsxBuffer[0].ulTargetDsxBuffer)
                return 1;
 
-        if(NULL == Adapter)
-        {
-                BCM_DEBUG_PRINT( Adapter,DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL, "Adapter was NULL!!!");
-                return 0;
-        }
-
        BCM_DEBUG_PRINT( Adapter,DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL, "Size of Each DSX Buffer(Also size of ServiceFlowParamSI): %zx ",sizeof(stServiceFlowParamSI));
        BCM_DEBUG_PRINT( Adapter,DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL, "Reading DSX buffer From Target location %x ",DSX_MESSAGE_EXCHANGE_BUFFER);