]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
[media] [v3,media] av7110: check for negative array offset
authorDan Carpenter <error27@gmail.com>
Fri, 7 Jan 2011 19:41:54 +0000 (16:41 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 19 Jan 2011 13:45:54 +0000 (11:45 -0200)
info->num comes from the user.  It's type int.  If the user passes
in a negative value that would cause memory corruption.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/ttpci/av7110_ca.c

index 122c72806916560ce6c3ce3c676e626c0ff7574d..9fc1dd0ba4c35fc1d6030fb17dc90fbe75d5d849 100644 (file)
@@ -277,7 +277,7 @@ static int dvb_ca_ioctl(struct file *file, unsigned int cmd, void *parg)
        {
                ca_slot_info_t *info=(ca_slot_info_t *)parg;
 
-               if (info->num > 1)
+               if (info->num < 0 || info->num > 1)
                        return -EINVAL;
                av7110->ci_slot[info->num].num = info->num;
                av7110->ci_slot[info->num].type = FW_CI_LL_SUPPORT(av7110->arm_app) ?