]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
mfd: wm831x-spi: Add NULL check before pointer dereference
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Wed, 24 May 2017 09:18:52 +0000 (04:18 -0500)
committerLee Jones <lee.jones@linaro.org>
Thu, 6 Jul 2017 07:29:11 +0000 (08:29 +0100)
Add NULL check before dereferencing pointer of_id in order to avoid
a potential NULL pointer dereference.

Addresses-Coverity-ID: 1408830
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/wm831x-spi.c

index c332e2885b26e2a5a1cbe50801149b6d48eca3ca..018ce652ae57d09e38e27315a265d7e5d96c5b5e 100644 (file)
@@ -34,6 +34,10 @@ static int wm831x_spi_probe(struct spi_device *spi)
 
        if (spi->dev.of_node) {
                of_id = of_match_device(wm831x_of_match, &spi->dev);
+               if (!of_id) {
+                       dev_err(&spi->dev, "Failed to match device\n");
+                       return -ENODEV;
+               }
                type = (enum wm831x_parent)of_id->data;
        } else {
                type = (enum wm831x_parent)id->driver_data;